Hoverformat bug with showTickLabels #267
Conversation
| }; | ||
|
|
||
| beforeEach(function() { | ||
| this. gd = createGraphDiv(); |
There was a problem hiding this comment.
Haha. Look at that. A jasmine this. Maybe I should start using those more.
There was a problem hiding this comment.
😸 I'm ok with this when it's idiomatic.
|
Great. Once you figured out if |
mdtusz
force-pushed
the
bug-hoverformat
branch
from
765d09d to
d8e09ee
Compare
|
@etpinard let's try to get this one in for the next release too if we can. |
| coerce('exponentformat'); | ||
| } | ||
| } | ||
|
|
||
| var tickPrefix = coerce('tickprefix'); | ||
| if(tickPrefix) coerce('showtickprefix', showAttrDflt); | ||
|
|
||
| var tickSuffix = coerce('ticksuffix'); | ||
| if(tickSuffix) coerce('showticksuffix', showAttrDflt); |
There was a problem hiding this comment.
These are not quite right still.
http://codepen.io/etpinard/pen/MKMNXe
tickprefix and ticksuffix have an effect (and should) on the hover labels; they should be coerced regardless of the showTickLabels value.
There was a problem hiding this comment.
Ah yeah that's what I had done before but I thought you were saying they should be in the showTickLabels block. I'll pull them out again then.
There was a problem hiding this comment.
Yeah, my bad. I wasn't very clear in my previous comment.
| coerce('exponentformat'); | ||
| } | ||
| var tickFormat = coerce('tickformat'); | ||
| if(!tickFormat && axType !== 'date') { |
There was a problem hiding this comment.
why is this block not wrapped inside axType !== 'category' ?
There was a problem hiding this comment.
Whoa good catch. When I pulled out coerce('hoverformat') I completely goofed on that. I'll add it into the if condition right now.
|
yeah man 💃 |
Hoverformat bug with showTickLabels
Fixes #261.
Pulled some of the coersions out from the block that checks for
showTickLabelsso things act as expected, and added a quick testeroonie in there for good measure in the future.