Skip to content

add empty protocol to link whitelist for IE relative links #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2017
Merged

add empty protocol to link whitelist for IE relative links #1715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d721d6
add empty protocol to link whitelist for IE relative links
alexcjohnson May 23, 2017
b5f5168
moar "no protocol" values for even more IE dialects
alexcjohnson May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib/svg_text_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,13 @@ var TAG_CLOSE = {
sub: '<tspan dy="-0.21em">&#x200b;</tspan>'
};

var PROTOCOLS = ['http:', 'https:', 'mailto:'];
/*
* Whitelist of protocols in user-supplied urls. Mostly we want to avoid javascript
* and related attack vectors. The empty items are there for IE, that in various
* versions treats relative paths as having different flavors of no protocol, while
* other browsers have these explicitly inherit the protocol of the page they're in.
*/
var PROTOCOLS = ['http:', 'https:', 'mailto:', '', undefined, ':'];

var STRIP_TAGS = new RegExp('</?(' + Object.keys(TAG_STYLES).join('|') + ')( [^>]*)?/?>', 'g');

Expand Down