Fire plotly_afterplot after Promise.all callback #1342
Conversation
| @@ -84,6 +84,21 @@ describe('Test plot api', function() { | |||
| expect(gd._transitionData._frames[2].name).toEqual('frame3'); | |||
| }).catch(fail).then(done); | |||
| }); | |||
|
|
|||
| it('should emit afterplot event after plotting is done', function(done) { | |||
There was a problem hiding this comment.
This test here fails on master.
I'm not exactly sure why though which might me related to #76
Consider:
var gd = document.getElementById('graph')
Plotly.plot(gd, [{}])
gd.on('plotly_afterplot', () => {})I suspect that on master the Plotly.plot promise is resolved before gd.on('plotly_relayout, /* */) is set. By tucking gd.emit('plotly_afterplot') is the Promise.all callback the Plotly.plot promise is resolved after gd.on.
There was a problem hiding this comment.
I suspect that on master the Plotly.plot promise is resolved before gd.on('plotly_afterplot, /* */) is set.
exactly - in most cases the plotting itself is sync, so your fix here is spot on.
|
💃 |
|
Just wondering, is this only fired on Curious, as I'd love to use this event with the React component, but that seems to use either: Thanks! |
|
Right, |
fixes #1341