Use trace gd.data index to determine dflt trace name #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ... instead of gd._fullData index - so that e.g. traces following one-to-many transform are listed as trace 1, ...
etpinard
commented
Oct 24, 2016
| return fullTrace.name; | ||
| }); | ||
|
|
||
| expect(names).toEqual([ |
There was a problem hiding this comment.
this ⏬ , this used to give
[
'trace 0 - increasing',
'trace 0 - decreasing',
'trace 2',
'trace 3 - increasing',
'trace 3 - decreasing',
'trace 5'
]
etpinard
commented
Oct 25, 2016
| @@ -722,9 +722,9 @@ plots.supplyFrameDefaults = function(frameIn) { | |||
| return frameOut; | |||
| }; | |||
|
|
|||
| plots.supplyTraceDefaults = function(traceIn, traceIndex, layout) { | |||
| plots.supplyTraceDefaults = function(traceIn, traceOutIndex, layout, traceInIndex) { | |||
There was a problem hiding this comment.
the odd call signature is to not break to toolpanel code:
|
looks 💃 to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1068