Added legends for boxplots and densities #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpsievert Hey Carson, do you know my graphs are not showing up the in the test tables? |
|
Ugh, I just spent a couple hours trying to debug. For some reason the pngs aren't being pushed appropriately, but not sure why. The current logic of the test table is super complicated, so if anything goes wrong, it's hard to fix it (this is a big reason why I'm changing the test table infrastructure in #226). I think my time is better spent finishing that new infrastructure. |
|
Thanks for checking it out! |
… into baobao-legend_hide
cpsievert
force-pushed
the
baobao-legend_hide
branch
from
6a7d67d to
5b077d7
Compare
Closed
cpsievert
added a commit
that referenced
this pull request
Dec 13, 2015
Added legends for boxplots and densities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a solution to Issue #212. The legends weren't showing up for boxplots and density plots is because those features were not part of
markLegendsinggplotly. I added them. I also made an except for boxplot so that is takesmarkSplitinstead. Finally, I added a test for boxplots where each box-and-whiskers has a different fill. Will add to the existing density plot tests tomorrow to check for legends.Now we can enjoy legends:
@cpsievert @mkcor @chriddyp