geom_smooth() #183
geom_smooth() #183
Conversation
|
The test table looks good to me -- Note the new tests -- http://ropensci.github.io/plotly-test-table/tables/9b5bbf306ada7d25d2f7d778f2cb11f69fc437d/smooth.html Perhaps I should add the cookbook scatterplot tests as well @tdhock @chriddyp @mkcor? On a related note, it might be worth having another checklist on #161 that tracks which of these testing files have been ported |
|
@cpsievert nice! yes, let's add the scatter plots cookbook file to this PR, as it contains a bunch of really good examples |
|
great, @cpsievert can you add your name to the table in the comment I just made on #161 ? |
|
on another note, it seems like the color mapping is off: |
|
cool, looks good! we don't have the notion of merged legend items. for this case, we could "hide" the other legend items use the trace property "showlegend" |
|
looks good 👍 ! @tdhock - will you do a code review too? |
| # always draw the line | ||
| misc$smoothLine <- TRUE | ||
| trace2 <- layer2traces(L, df, misc) | ||
| trace2 <- lapply(trace2, function(x) { x$showlegend <- FALSE; x }) |
There was a problem hiding this comment.
I think it is confusing to use lapply with an anonymous function here where you could have used a for loop.
There was a problem hiding this comment.
@tdhock What?! I would say that, in R, you want to use *ply functions (in order to avoid for loops) as much as possible!!
|
I managed to avoid geom specific code in ggplotly.R via a recursive call to |
|
+1 thanks for making that change! Everything looks good to me, in the code and on the test table. |
This will close #179.