-
-
Notifications
You must be signed in to change notification settings - Fork 544
Add Mucho Marker example to docs #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
etpinard
commented
Jul 15, 2014
- fig : https://plot.ly/~etpinard/435/
- mucho marker : https://github.com/plotly/streambed/pull/358
Awesome! It's clear to me how I would add dots or not fill markers, but maybe you could just do a few examples of that on the right? I.e., put another column at the right with a few examples of using |
I'll see what I can do. This layout is pretty much saturated for a 500px X 500px docs figure. |
new fig --> https://plot.ly/~etpinard/435/500/500/ |
yup! that's perfect! 🐖 |
... I'd love to get 👍 from @alexander-daniel or @chriddyp before merging this. |
🍧 delicious! |
is the marker number the only way to do this? if you can also supply a string, still, then I think we should include it. |
@chriddyp correct. The corresponding marker symbol strings appear on hover. |
@@ -5,5 +5,5 @@ | |||
"description": "How to make line and scatter plots in {language}. {num_examples} examples of basic and colored line and scatter plots.", | |||
"order": ["matlab-line-and-scatter-basic", | |||
"gg-basic-line", "gg-basic-scatter", "gg-line-scatter", "gg-alpha", | |||
"basic-line", "line-scatter", "line-style"] | |||
"basic-line", "line-scatter", "line-style", "marker-symbols"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it confusing that this will be peoples first introduction to setting arrays for attributes inside a trace? previously, we introduced this concept in the bubble charts section. people might think that to set a trace to square symbols , you have to set a symbol array, and set every single element in that array to "square". .. you know what I mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another solution might be to include an example with customized per -trace properties, e.g. color, symbol, and then include a "prepend" or "append" (cc @EnginEAR, @alex-vados) note that has a link to this example, "to see all possible marker types"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Would you recommend making 45 traces instead?
Or putting https://plot.ly/~etpinard/435/500/500/ is bubble-charts/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might also want to include an example like (or identical) to the bubble charts example in "line-and-scatter" section, to show people how to set properties as an array inside a trace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or just a few traces (5) and include a prepend section with a link to the reference section and your example of every single symbol type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-vados - could you wire in the prepend and append section to the docs template?
Hmm. Ok I'll wait for a consensus before merging this. |
Or, to relate to #18, maybe we should have an Advanced styling section separated from Chart types with pages for color, color scales, symbols, etc ... |
I think this should probably get linked elsewhere as it applies to both bubbles and line+scatter. for my 2 cents. |
@etpinard, is this PR still relevant? |
@theengineear Relevant for sure. I still think we should have this example in our docs. That said,
Thoughts? |
Gotcha, I thought it might have gotten into documentation through a different branch. Yeah, this should definitely be in there. Perhaps a name like "Plot styling" might attract better searches though? Either way, yeah, I could foresee a number of examples getting filed there. |
I like the sound of Plot styling. @alexander-daniel @chriddyp Thoughts? |
All the colorscale plots on https://plot.ly/python/heatmaps/ would better fit under Plot styling / Color scales in my mind. |
Plot styling! I think that's a good idea. Moving to another repo! |