Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Modified CONTRIBUTING.md with publishing guide #243

Merged
merged 7 commits into from
Jul 30, 2018
Merged

Conversation

wbrgss
Copy link
Contributor

@wbrgss wbrgss commented Jul 24, 2018

Follow-up on a task in the onboarding checklist:

I have access to the Github repos I need to do my work and I've read their CONTRIBUTING docs or complained that they don't exist

Included @chriddyp's guide to publishing new components. Related: PR #52 on dash-html-components

@wbrgss wbrgss force-pushed the wbrgss-contributing branch from 0c36f35 to bc5fdbf Compare July 26, 2018 18:44
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion but otherwise lgtm!
💃

CONTRIBUTING.md Outdated

## Pull Request Guidelines

Using the [GitHub flow][] is encouraged when proposing contributions to this repository (i.e. creating a feature branch and submitting a PR on the master branch).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comment here-- more mandatory than encouraged :D

@wbrgss wbrgss merged commit f9b2e93 into master Jul 30, 2018
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the wbrgss-contributing branch September 25, 2019 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants