Skip to content

Update for DFRobot ESP32 boards #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2022
Merged

Update for DFRobot ESP32 boards #829

merged 5 commits into from
Jul 19, 2022

Conversation

doskoi
Copy link
Contributor

@doskoi doskoi commented Jun 11, 2022

  • Add new product Beetle ESP32-C3
  • Fix the wrong config from Firebeetle ESP32

@doskoi doskoi changed the title Update ESP32 and C3 for DFRobot Update for DFRobot ESP32 boards Jun 11, 2022
@valeros
Copy link
Member

valeros commented Jun 14, 2022

Hi @doskoi , thanks for the PR. I don't see the beetle32c3 variant present in the official ESP32 Arduino core https://github.com/espressif/arduino-esp32/tree/master/variants. Please add your variant to that repository and once it's available in the stable release it will be added to PlatformIO.

@doskoi
Copy link
Contributor Author

doskoi commented Jun 14, 2022 •
edited
Loading

Sure, the PR has raised
espressif/arduino-esp32#6869

unlogisch04
unlogisch04 reviewed Jul 9, 2022
View reviewed changes
unlogisch04
unlogisch04 reviewed Jul 9, 2022
View reviewed changes
doskoi and others added 2 commits July 9, 2022 16:26
@unlogisch04 unlogisch04 mentioned this pull request Jul 11, 2022
Merged
9 tasks
@valeros
Small improvements for DFRobot Beetle ESP32-C3
0353171 
- Renamed board ID
- Added HWIDs
- Updated  default defines, name and URL
- Consistent formatting
@valeros valeros merged commit cb35838 into platformio:develop Jul 19, 2022
@valeros
Copy link
Member

valeros commented Jul 19, 2022

Thanks for the PR, merged!

egnor pushed a commit to egnor/platform-espressif32 that referenced this pull request Aug 11, 2022
@doskoi @egnor
Update for DFRobot ESP32 boards (platformio#829)
229ff42 
* fix: correcting hardware config for firebeetle-32
* add: DFRobot Beetle 32C
@unlogisch04
Copy link

What was there a reason to remove"-DARDUINO_USB_CDC_ON_BOOT=1"?
Currently i only get when i use Serial.println("abc"); nothing on the output. But i get debug output. [ 9515][E][WiFiSTA.cpp:317] .... with the "-DARDUINO_USB_CDC_ON_BOOT=1" i get the expected output.
The USB Serial Port is directly connected to the ESP Chip.

@valeros
Copy link
Member

valeros commented Aug 12, 2022

We tend to use the same settings as in the Arduino IDE. By default, the CDC is disabled there https://github.com/espressif/arduino-esp32/blob/master/boards.txt#L6218. If you think it's a mistake, feel free to provide a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlogisch04 unlogisch04 unlogisch04 left review comments

Assignees
No one assigned
Labels
board request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doskoi @valeros @unlogisch04