Skip to content

No quotes included in define for custom board_build.partitions #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fionn-r opened this issue May 2, 2022 · 2 comments · Fixed by espressif/arduino-esp32#6681
Closed

No quotes included in define for custom board_build.partitions #787

fionn-r opened this issue May 2, 2022 · 2 comments · Fixed by espressif/arduino-esp32#6681

Comments

@fionn-r
Copy link

fionn-r commented May 2, 2022

Configuration

Operating system: Ubuntu 20.04

PlatformIO Version (platformio --version):

❯ platformio --version
PlatformIO Core, version 6.0.0a2

platform = [email protected]

Description of problem

Board is esp-wrover-kit

When I set a custom board_build.partitions to a path (e.g. board_build.partitions = extras/partition_table), the generated call to g++ doesn't add quotes around extras/partition_table and causes a warning: ISO C++11 requires whitespace after the macro name for every object compiled.

Steps to Reproduce

  1. Create a project with a custom board_puild.partitions
  2. Build the firmware and check the output logs.

Actual Results

A lot of <command-line>: warning: ISO C++11 requires whitespace after the macro name is printed. Also, building in debug mode you can see that -DARDUINO_PARTITION_firmware-shared-libs/system/partition_table is a parameter to g++.

Expected Results

-DARDUINO_PARTITION_firmware-shared-libs/system/partition_table is defined instead as -DARDUINO_PARTITION_\"firmware-shared-libs/system/partition_table\"
@fionn-r fionn-r changed the title No quotes included in deefine for custom board_build.partitions No quotes included in define for custom board_build.partitions May 2, 2022
@zekageri
Copy link

zekageri commented May 2, 2022

I can confirm this

@valeros valeros mentioned this issue May 3, 2022
Merged
me-no-dev pushed a commit to espressif/arduino-esp32 that referenced this issue May 4, 2022
@valeros
Properly handle ARDUINO_PARTITION define in PlatformIO (#6681)
4453ca5 
This fixes possible issues when developers specify arbitrary partition files
using relative or absolute paths.

Additionally, hyphens in filenames are replaced with underscores to
avoid compilation warnings "ISO C++11 requires whitespace after the macro name"

Resolves platformio/platform-espressif32#787
@valeros
Copy link
Member

valeros commented May 4, 2022

Resolved in espressif/arduino-esp32#6681

@valeros valeros closed this as completed May 4, 2022
@henrygab henrygab mentioned this issue Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly handle ARDUINO_PARTITION define in PlatformIO valeros/arduino-esp32
3 participants
@valeros @fionn-r @zekageri