readme: add notes about Docker for MacOS users #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilin90
reviewed
Jul 20, 2018
README.md
Outdated
| @@ -5,6 +5,8 @@ | |||
| * Docker >= 16.10 | |||
| * Docker Compose >= 1.6.0 | |||
|
|
|||
| *Note*: [Legacy Docker Toolbox](https://docs.docker.com/toolbox/toolbox_install_mac/) users should migrate to [Docker for Mac](https://store.docker.com/editions/community/docker-ce-desktop-mac), since it is tested that tidb-docker-compose can't started on Docker Toolbox and Docker Machine. | |||
There was a problem hiding this comment.
- Please follow our note format:
> **Note:** - should -> must
- can't started -> cannot be started
lilin90
changed the title
tennix
added a commit
that referenced
this pull request
Aug 15, 2018
readme: add notes about Docker for MacOS users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates README to inform MacOS users using Docker for Mac. It closes #23 and closes #28
PTAL @lilin90