-
Notifications
You must be signed in to change notification settings - Fork 92
Speed up client initialization with lazy loading #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jhamon
wants to merge
23
commits into
release-candidate/2025-04
Choose a base branch
from
jhamon/client-reorg
base: release-candidate/2025-04
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b89d903
to
cd15bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the upcoming release we want to take a dependency on the Assistants plugin. But we don't want this dependency to come at a cost of degraded performance for users who are not using the features in the plugin.
Solution
To accomplish these goals I wanted to do some significant refactoring without breaking any existing functionality.
Initialization performance
To assess the load time for the pinecone package, I used a built-in package called
importtime
.Then I visualized the results using a new dev-dependency called
tuna
These steps can be used to show that before any refactoring, the initialization time was more than 300ms(!)
After refactoring to make
PluginAware
lazy, and also restructure code related to operations on indexes, collections, inference, etc to take advantage of lazy loading we can improve the client initialization time very significantly. This is a big improvement because it means users will no longer need to wait to load a bunch of code for features they are not using.Type of Change
Test Plan
Describe specific steps for validating this change.