STM32 support #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone else has already gone through the trouble of porting the ArduinoBLE library to STM32,
all i did was copy the NanoIOT headers and added some minor preamble.
Also, i chose to 'fix'(?) a compiler warning regarding a zero-sized char array for setting MTU size in (presumably JSON code of) experiment.cpp
NOTE: personally, i would rename the NanoIOT.h header and cpp, be the 'general/basic' ArduinoBLE implementation,
then one could delete the copied code from the new STM32 header & cpp, and just refer to the (former) NanoIOT header.
an int64_t was initialized to NULL instead of 0, the compiler threw a warning
|
First of all sorry, for some reasons neither Dominik nor I had notifications enabled for this repo (changed that now) and I only noticed it just now when Dominik stumbled upon it. It looks good to me and I am very happy to see STM32 support as this is certainly another rather relevant microcontroller. (And including a little fix on the side that looks a lot like we were writing to unallocated memory.) I will merge it and make a release soon. |
|
nice! thank you for taking it off my hands ;). Let me know if there's anything you'd like me to do |
Staacks
added a commit
that referenced
this pull request
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the STM32duinoBLE library provides an ArduinoBLE compatibility layer for several STM32 microcontrollers (including the STM32WB55 that i'm using). Using this library, i've added STM32 support to phyphox BLE. (i did almost nothing, as the STM32duinoBLE library is quite good, and includes all the difficult code, i basically just copy-pasted some example code).
I tested it briefly (using only the STM32WB55 nucleo dev kit that i have on hand), so there is significant room for error, BUT assuming that the STM32duinoBLE library is relatively on-par/up-to-date with the ArduinoBLE library, all the Nano 33 BLE (or Nano IOT?) code should work.
I copied the contents of the _NanoIOT header and .cpp, only adding some minor prefixes. I would like to see this reformatted as: one general header + cpp for 'default' ArduinoBLE implementations, and an STM32 and NanoIOT header that both point to this general header. Is that something the maintainers of this repo would prefer to handle? (to make sure the code stays legible), or should i take a swing at it?