Fix: An array can have only integers or strings as keys #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voku
changed the title
jaapio
requested changes
Oct 2, 2021
src/Types/ClassString.php
Outdated
|
|
||
| /** | ||
| * Value Object representing the type 'string'. | ||
| * | ||
| * @psalm-immutable | ||
| */ | ||
| final class ClassString implements Type | ||
| final class ClassString extends String_ |
There was a problem hiding this comment.
I think we forgot this one when introducing the PseudoType interface, Could you please add that as well here.
jaapio
reviewed
Oct 2, 2021
src/Types/ArrayKey.php
Outdated
| { | ||
| public function __construct() | ||
| { | ||
| parent::__construct([new String_(), new Integer()], '|'); | ||
| } | ||
|
|
||
| public function underlyingType(): Type | ||
| { | ||
| return new String_(); |
There was a problem hiding this comment.
This seems incorrect to me, this type is not a string, it should return a Compound with the types String_ and Integer. ArrayKey is an alternative notation for String|Int, not just String
jaapio
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow all kind of string types here. We currently do not have an array-key interface or something like that, so I added the new type into the check.