Add true and false as PseudoTypes #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this change, I have made more allowance for identifying types as PseudoTypes and to ensure they are identified as both their underlying and pseudo-type. Using instanceof, you can identify whether it is the PseudoType, a pseudotype, but also as the underlying type.
…dd-pseudo-type-support-and-use-true-and-false
…pseudo-type-support-and-use-true-and-false
jaapio
requested changes
Aug 22, 2020
|
The BC break mentioned in the build is mitigated by using class_alias in the False_ and True_ classes. The tool is apparently unable to detect that and I even added a test to check the BC |
In order to keep BC compatiblity, I had to introduce class_alias calls in the True_ and False_ classes. This has a side-effect, which the phpcs fails on.
jaapio
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, I have made more allowance for identifying types as
PseudoTypes and to ensure they are identified as both their underlying
and pseudo-type.
Using instanceof, you can identify whether it is the PseudoType, a
pseudotype, but also as the underlying type.