Enhancement: Enable braces_position fixer
#881
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
Dec 7, 2023
| @@ -24,6 +24,7 @@ | |||
| 'array_syntax' => true, | |||
| 'binary_operator_spaces' => true, | |||
| 'blank_line_after_namespace' => true, | |||
| 'braces_position' => true, | |||
There was a problem hiding this comment.
Alternatively, this fixer could also be configured with a range of options.
Comment on lines
+22
to
+23
| function imgheader($filename) | ||
| { |
There was a problem hiding this comment.
I don't like this. Also, I think this fixer should be applied together with indentation fixer.
There was a problem hiding this comment.
Maybe #886 helps, @kamil-tekiela?
There was a problem hiding this comment.
To be honest, I would hold off with applying either of them. It creates too many changes and I don't know if this project is ready for this yet. I'd rather take small steps here.
|
I could rebase this pull request after the merge of #934. |
|
Closing as requested by @pronskiy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
braces_positionfixermake coding-standardsFollows #559.
💁♂️ For reference, see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.40.2/doc/rules/basic/braces_position.rst.