Skip to content

Enhancement: Enable blank_line_after_opening_tag fixer #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 7, 2023

This pull request

  • enables the blank_line_after_opening_tag fixer
  • runs make coding-standards

Follows #559.

πŸ’β€β™‚οΈ For reference, see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.40.2/doc/rules/php_tag/blank_line_after_opening_tag.rst.

@localheinz localheinz mentioned this pull request Dec 7, 2023
1 task
@derickr
Copy link
Member

derickr commented Dec 7, 2023

I don't understand why you'd want the blank line here? It seems useless.

@localheinz localheinz force-pushed the feature/blank-line-after-opening-tag branch from b704bb7 to 4fba76d Compare December 7, 2023 11:50
@localheinz localheinz force-pushed the feature/blank-line-after-opening-tag branch from 5bebc58 to 1a51c97 Compare December 7, 2023 15:46
@kamil-tekiela kamil-tekiela merged commit 59c070f into php:master Dec 7, 2023
@localheinz localheinz deleted the feature/blank-line-after-opening-tag branch December 7, 2023 16:02
@localheinz
Copy link
Contributor Author

Thank you, @derickr and @kamil-tekiela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants