Skip to content

Enhancement: Enable function_declaration fixer #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Enhancement: Enable function_declaration fixer #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aab632
Enhancement: Enable function_declaration fixer
localheinz Dec 6, 2023
21b440b
Fix: Run 'make coding-standards'
localheinz Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .php-cs-fixer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
],
'constant_case' => true,
'elseif' => true,
'function_declaration' => true,
'increment_style' => [
'style' => 'post',
],
Expand Down
4 changes: 2 additions & 2 deletions include/errors.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ The most commonly searched terms have also been added.
TODO: Determine if we want to continue 301 -OR- make these official URLs.
******************************************************************************/

function is_known_ini (string $ini): ?string {
function is_known_ini(string $ini): ?string {
$inis = [
'engine' => 'apache.configuration.php#ini.engine',
'short-open-tag' => 'ini.core.php#ini.short-open-tag',
Expand Down Expand Up @@ -366,7 +366,7 @@ function is_known_variable(string $variable): ?string {
return $variables[ltrim($variable, '$')] ?? null;
}

function is_known_term (string $term): ?string {
function is_known_term(string $term): ?string {
$terms = [
'<>' => 'language.operators.comparison.php',
'<=>' => 'language.operators.comparison.php',
Expand Down
4 changes: 2 additions & 2 deletions include/layout.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,15 @@ function make_submit($file, $alt = false, $align = false, $extras = false,
}

// Return a hiperlink to something within the site
function make_link (string $url, string $linktext = ''): string
function make_link(string $url, string $linktext = ''): string
{
return sprintf("<a href=\"%s\">%s</a>", $url, $linktext ?: $url);
}

// make_popup_link()
// return a hyperlink to something, within the site, that pops up a new window
//
function make_popup_link ($url, $linktext = false, $target = false, $windowprops = "", $extras = false) {
function make_popup_link($url, $linktext = false, $target = false, $windowprops = "", $extras = false) {
return sprintf("<a href=\"%s\" target=\"%s\" onclick=\"window.open('%s','%s','%s');return false;\"%s>%s</a>",
htmlspecialchars($url, ENT_QUOTES | ENT_IGNORE),
($target ?: "_new"),
Expand Down