Skip to content

Enhancement: Enable and configure increment_style fixer #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Sep 11, 2022

This pull request

  • enables and configures the increment_style fixer
  • runs make coding-standards

Replaces #545.
Follows #559.

💁‍♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/operator/increment_style.rst.

@localheinz localheinz force-pushed the feature/increment-style branch from d64001d to 3cab00b Compare September 11, 2022 21:02
@cmb69
Copy link
Member

cmb69 commented Sep 12, 2022

Thank you for the PR!

Maybe we should stick with 'post'?

Co-authored-by: Andreas Möller <[email protected]>
Co-authored-by: Mathias Reker <[email protected]>
@localheinz localheinz force-pushed the feature/increment-style branch from 3cab00b to 6483442 Compare September 12, 2022 13:06
Co-authored-by: Andreas Möller <[email protected]>
Co-authored-by: Mathias Reker <[email protected]>
@localheinz
Copy link
Contributor Author

@cmb69

Adjusted!

@localheinz localheinz changed the title Enhancement: Enable increment_style fixer Enhancement: Enable and configure increment_style fixer Sep 12, 2022
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@cmb69 cmb69 merged commit 2ae10ff into php:master Sep 12, 2022
@localheinz localheinz deleted the feature/increment-style branch September 12, 2022 15:16
@localheinz
Copy link
Contributor Author

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants