Enhancement: Enable new_with_braces fixer
#697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Mathias Reker <[email protected]>
localheinz
changed the title
new_with_braces fixer
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Mathias Reker <[email protected]>
localheinz
force-pushed
the
feature/new-with-braces
branch
from
7600661 to
bfa5268
Compare
|
Thank you for the PR! This is fine for me, but @kamil-tekiela was against that in #540, and maybe others don't like this either. So let's wait for more feedback. |
|
I'm also fine with this. Not sure how much feedback we'll get ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
new_with_bracesfixermake coding-standardsReplaces #540.
Follows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/operator/new_with_braces.rst.