Enhancement: Enable binary_operator_spaces fixer
#667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
approved these changes
Jul 18, 2022
Comment on lines
-366
to
+376
| 'id' => $id, | ||
| 'type' => $tipo, | ||
| 'start' => $sdato, | ||
| 'end' => $edato, | ||
| 'recur' => $recur, | ||
| 'id' => $id, | ||
| 'type' => $tipo, | ||
| 'start' => $sdato, | ||
| 'end' => $edato, | ||
| 'recur' => $recur, | ||
| 'recur_day' => $recur_day, | ||
| 'sdesc' => $sdesc, | ||
| 'url' => $url, | ||
| 'ldesc' => base64_decode($ldesc, false), | ||
| 'country' => $country, | ||
| 'category' => $category, | ||
| 'sdesc' => $sdesc, | ||
| 'url' => $url, | ||
| 'ldesc' => base64_decode($ldesc, false), | ||
| 'country' => $country, | ||
| 'category' => $category, |
There was a problem hiding this comment.
I don't like such vertical alignments, but others may, so let's wait a while for possible objections.
There was a problem hiding this comment.
For the record, it is also possible to configure the spacing per operator: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/operator/binary_operator_spaces.rst.
localheinz
force-pushed
the
feature/binary-operator-spaces
branch
from
b61ef7a to
219a7b8
Compare
localheinz
force-pushed
the
feature/binary-operator-spaces
branch
from
da7480d to
6a6d550
Compare
|
No objections, so I'm going to merge. Thank you, @localheinz! |
|
Thank you, @cmb69! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
binary_operator_spacesfixermake coding-standardsFollows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/operator/binary_operator_spaces.rst.