Enhancement: Enable void_return fixer

[localheinz]

This pull request

• enables the (risky) void_return fixer
• runs make coding-standards

Follows #559.

💁‍♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/function_notation/void_return.rst.

[localheinz]

The method does not return anything.

web-php/src/UserNotes/Sorter.php

Lines 18 to 37 in d8717d3

	public function sort(array &$notes) {
	// First we make a pass over the data to get the min and max values
	// for data normalization.
	$this->findMinMaxValues($notes);
	$this->voteFactor = $this->maxVote - $this->minVote
	? (1 - .3)/ ($this->maxVote - $this->minVote)
	: .5;
	$this->ageFactor = $this->maxAge - $this->minAge
	? 1 / ($this->maxAge - $this->minAge)
	: .5;
	$this->ageFactor *= $this->ageWeight;
	// Second we loop through to calculate sort priority using the above numbers
	$this->calcSortPriority($notes);
	// Third we sort the data.
	uasort($notes, array($this, 'factorSort'));
	}

[localheinz]

The method does not return anything.

web-php/src/UserNotes/Sorter.php

Lines 78 to 108 in d8717d3

	private function findMinMaxValues(array &$notes) {
	$count = count($notes);
	if ($count <= 0) {
	return;
	}
	$note = array_shift($notes);
	$note['score'] = $net = ($note['votes']['up'] - $note['votes']['down']);
	$note['total'] = $totalVotes = ($note['votes']['up'] + $note['votes']['down']);
	$note['rating'] = $totalVotes > 0
	? $note['votes']['up'] / $totalVotes
	: .5;
	$this->minVote = $this->maxVote = $net;
	$this->minAge = $this->maxAge = $age = $note['xwhen'];
	$first = $note;
	foreach ($notes as &$note) {
	$note['score'] = $net = ($note['votes']['up'] - $note['votes']['down']);
	$note['total'] = $totalVotes = ($note['votes']['up'] + $note['votes']['down']);
	$note['rating'] = $totalVotes > 0
	? $note['votes']['up'] / $totalVotes
	: .5;
	$age = $note['xwhen'];
	$this->maxVote = max($this->maxVote, $net);
	$this->minVote = min($this->minVote, $net);
	$this->maxAge = max($this->maxAge, $age);
	$this->minAge = min($this->minAge, $age);
	}
	array_unshift($notes, $first);
	}

[kamil-tekiela]

Can you please resolve conflicts?

[derickr]

This still has conflicts :-)

[localheinz]

Rebased!

[kamil-tekiela]

Thanks. This should be fine.

[localheinz]

Thank you, @derickr and @kamil-tekiela!