Skip to content

Enhancement: Enable constant_case fixer #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 15, 2022

This pull request

  • enables the constant_case fixer
  • runs make coding-standards

Replaces #537.
Follows #559.

💁‍♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/casing/constant_case.rst.

localheinz and others added 2 commits July 15, 2022 13:21
Co-authored-by: Andreas Möller <[email protected]>
Co-authored-by: MathiasReker <[email protected]>
Co-authored-by: Andreas Möller <[email protected]>
Co-authored-by: MathiasReker <[email protected]>
@localheinz localheinz marked this pull request as ready for review July 15, 2022 11:23
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmb69 cmb69 merged commit d7e1b81 into php:master Jul 15, 2022
@cmb69
Copy link
Member

cmb69 commented Jul 15, 2022

Thank you!

@cmb69 cmb69 mentioned this pull request Jul 15, 2022
@localheinz localheinz deleted the feature/constant-case branch July 15, 2022 12:03
@localheinz
Copy link
Contributor Author

Thank you, @cmb69 and @kamil-tekiela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants