Skip to content

Enhancement: Enable PSR12 rule set #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enhancement: Enable PSR12 rule set #638

wants to merge 2 commits into from

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 11, 2022 •
edited
Loading

This pull request

  • enables the PSR12 rule set
  • runs make coding-standards

Follows #559.

@localheinz localheinz marked this pull request as ready for review July 11, 2022 17:42
@localheinz localheinz mentioned this pull request Jul 11, 2022
Merged
2 tasks
@localheinz localheinz force-pushed the feature/psr-12 branch 3 times, most recently from 7a7e7a9 to 0c8dfe6 Compare July 11, 2022 17:47
@localheinz
Copy link
Contributor Author

@cmb69

I think this does not work very well:

  • changes are hard to review
  • mixing PHP code and HTML code is something that is not officially supported by friendsofphp/php-cs-fixer

When enabling fixers one by one, we have more control.

@localheinz localheinz marked this pull request as draft July 11, 2022 18:08
@localheinz localheinz marked this pull request as draft July 11, 2022 18:08
@cmb69
Copy link
Member

cmb69 commented Jul 11, 2022

Yes, I have to agree!

@cmb69 cmb69 closed this Jul 11, 2022
@localheinz localheinz deleted the feature/psr-12 branch July 11, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saundefined saundefined Awaiting requested review from saundefined saundefined will be requested when the pull request is marked ready for review saundefined is a code owner

@sy-records sy-records Awaiting requested review from sy-records sy-records will be requested when the pull request is marked ready for review sy-records is a code owner

@sgolemon sgolemon Awaiting requested review from sgolemon sgolemon will be requested when the pull request is marked ready for review sgolemon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @cmb69