Enhancement: Add tests for gen_challenge() and test_answer()
#632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Thank you for the PR! Testing test_answer() definitely makes sense. I'm not sure about the gen_challenge() test, since using rand() might not be the best idea anyway, so that we needed to mock the random number generator anyway. OTOH, we could still rewrite the test, so I guess this is good as is.
|
Are there any objections to merging this pull request? |
kamil-tekiela
approved these changes
Jul 15, 2022
|
Thank you! |
|
Thank you, @cmb69 and @kamil-tekiela! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
gen_challenge()andtest_answer()Follows #626.