-
Notifications
You must be signed in to change notification settings - Fork 558
Enhancement: Add CONTRIBUTING.md
#615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f053207
to
f63017a
Compare
f63017a
to
533908c
Compare
Thank you! This is certainly a good start, but what about:
I think at least the first item should be addressed right away. |
Perhaps the first item could be better addressed with https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates? |
For the third item, this probably helps: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-code-of-conduct-to-your-project. |
It would be good to have a guide similar to https://github.com/php/php-src/blob/master/CONTRIBUTING.md but shorter. |
Issue templates might be useful, but some more general info (like in php-src's CONTRIBUTING.md as @kamil-tekiela pointed out) should be good for now. Regarding a CoC: IIRC that was discussed quite a while ago for php-src, but went nowhere. I'm afraid the situation would be the same for web-php. |
533908c
to
b79dccc
Compare
Updated |
- Run | ||
|
||
``` | ||
php tests/run-tests.php -q --show-diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see #621.
5. Test your changes before committing them. We mean it. Really. To do so use | ||
|
||
``` | ||
php tests/run-tests.php -q --show-diff`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see #621.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Much better, in my opinion, but still a few tweaks could be applied.
Co-authored-by: Andreas MΓΆller <[email protected]> Co-authored-by: Christoph M. Becker <[email protected]>
ad07c94
to
cc4ce07
Compare
Adjusted! |
Thank you, @localheinz! Wrt. #621, we can adjust CONTRIBUTING.md later. |
Thank you, @cmb69 and @kamil-tekiela! |
This pull request
CONTRIBUTING.md
πββοΈ For reference, see https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors#adding-a-contributing-file.