Random Extension 5.x follow-up

[zeriyoshi]

The Random Extension 5.x and Random Extension Improvement proposals passed, but with the problem of argument overloading.

#8094

As noted by some, argument overloading is now discouraged and should not be implemented anew.

• https://externals.io/message/118163#118269
• https://github.com/php/php-src/pull/8094/files#r919693108

This changes separates the argumentless Random\Randomizer::getInt() into Random\Randomizer::nextInt().

At the same time, compatibility header files for internal APIs were removed.
This may affect downstream extensions, but can be easily circumvented by macro-branching with PHP_VERSION_ID.

• https://github.com/php/php-src/pull/8094/files#r917308676

[TimWolla]

Thanks. I've already picked the first comment for the change to EXTENSIONS into d43e55b, because that one definitely is good, whereas the rest will need some discussion.

[kocsismate]

The result cannot be not int due to the return type

[zeriyoshi]

fixed in new PR: #9057

[TimWolla]

@zeriyoshi One request for the future: Can you split unrelated changes into separate PRs? In this case: One for the EXTENSIONS file (which I already merged), one for the headers and one for getInt/nextInt. That makes it easier to independently review and merge them.

[zeriyoshi]

@TimWolla
OK, This PR will focus on nextInt() / getInt().

[zeriyoshi]

Since it is complicated, I would like to close this PR and create a new PR.

[zeriyoshi]

@TimWolla @kocsismate
These PRs were separated. (It appears that the EXTENSIONS changes are already in master. Thanks)

• [random] split getInt() with no arguments into nextInt() #9057
• [random] remove unnecessary old header files #9058

[iluuu1994]

This caused two UBSAN failures:

https://github.com/php/php-src/runs/7420828169?check_suite_focus=true

========DIFF========
001+ /home/runner/work/php-src/php-src/ext/random/random.c:322:24: runtime error: signed integer overflow: 9223372036854775807 - -9223372036854775808 cannot be represented in type 'long int'
     Random\Engine\Mt19937: success
     Random\Engine\Mt19937: success
005+ /home/runner/work/php-src/php-src/ext/random/random.c:325:55: runtime error: signed integer overflow: -9223372036854775808 + -1050901053848098914 cannot be represented in type 'long int'
     Random\Engine\Xoshiro256StarStar: success
     Serialization of 'Random\Engine\Secure' is not allowed
     Serialization of 'Random\Engine@anonymous' is not allowed
--
========DONE========
FAIL Random: Randomizer: serialize [ext/random/tests/03_randomizer/serialize.phpt] 

========DIFF========
001+ /home/runner/work/php-src/php-src/ext/random/random.c:322:24: runtime error: signed integer overflow: 9223372036854775807 - -9223372036854775808 cannot be represented in type 'long int'
     Random number generation failed
     Random number generation failed
     Random number generation failed
006+ /home/runner/work/php-src/php-src/ext/random/random.c:325:55: runtime error: signed integer overflow: -9223372036854775808 + -1 cannot be represented in type 'long int'
     int(%d)
     string(2) "ff"
     Random number generation failed
--
========DONE========
FAIL Random: Randomizer: User: Engine unsafe [ext/random/tests/03_randomizer/user_unsafe.phpt] 

@zeriyoshi Could you have a look? Thanks!

[zeriyoshi]

This caused two UBSAN failures:

https://github.com/php/php-src/runs/7420828169?check_suite_focus=true

========DIFF========
001+ /home/runner/work/php-src/php-src/ext/random/random.c:322:24: runtime error: signed integer overflow: 9223372036854775807 - -9223372036854775808 cannot be represented in type 'long int'
     Random\Engine\Mt19937: success
     Random\Engine\Mt19937: success
005+ /home/runner/work/php-src/php-src/ext/random/random.c:325:55: runtime error: signed integer overflow: -9223372036854775808 + -1050901053848098914 cannot be represented in type 'long int'
     Random\Engine\Xoshiro256StarStar: success
     Serialization of 'Random\Engine\Secure' is not allowed
     Serialization of 'Random\Engine@anonymous' is not allowed
--
========DONE========
FAIL Random: Randomizer: serialize [ext/random/tests/03_randomizer/serialize.phpt] 

========DIFF========
001+ /home/runner/work/php-src/php-src/ext/random/random.c:322:24: runtime error: signed integer overflow: 9223372036854775807 - -9223372036854775808 cannot be represented in type 'long int'
     Random number generation failed
     Random number generation failed
     Random number generation failed
006+ /home/runner/work/php-src/php-src/ext/random/random.c:325:55: runtime error: signed integer overflow: -9223372036854775808 + -1 cannot be represented in type 'long int'
     int(%d)
     string(2) "ff"
     Random number generation failed
--
========DONE========
FAIL Random: Randomizer: User: Engine unsafe [ext/random/tests/03_randomizer/user_unsafe.phpt] 

@zeriyoshi Could you have a look? Thanks!

@iluuu1994
Thanks!
I fixed it. Could you please check? #9060