zend_compile: Set op_array->scope for Closures as compile time
#18552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
May 14, 2025
|
Okay, based on the discussion in #10782 this fix might break some optimization assumptions. I'll let the tests run just to see what they do, but I'm happy to just close and let someone more experienced with the engine do a proper fix. |
mvorisek
reviewed
May 14, 2025
| @@ -8462,6 +8462,15 @@ static zend_op_array *zend_compile_func_decl_ex( | |||
| /* Pop the loop variable stack separator */ | |||
| zend_stack_del_top(&CG(loop_var_stack)); | |||
|
|
|||
| if (op_array->fn_flags & ZEND_ACC_CLOSURE) { | |||
There was a problem hiding this comment.
In #10782 (comment) there is also a condition to skip this for traits, not sure, but highly likely there is a missing test for it with observer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #18546