-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix ReflectionFunction::isDeprecated() for materialized __call()
#17914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TimWolla
merged 3 commits into
php:PHP-8.4
from
TimWolla:reflectionfunction-is-deprecated-magic-call
Feb 27, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
ext/reflection/tests/ReflectionFunction_isDeprecated_magic_call.phpt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| --TEST-- | ||
| GH-17913: ReflectionClassConstant::isDeprecated() with __call() and __callStatic() | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| class Clazz { | ||
| #[\Deprecated] | ||
| function __call(string $name, array $params) { | ||
| } | ||
|
|
||
| #[\Deprecated("due to some reason")] | ||
| static function __callStatic(string $name, array $params) { | ||
| } | ||
| } | ||
|
|
||
| $foo = new Clazz; | ||
| $closure = Closure::fromCallable([$foo, 'test']); | ||
|
|
||
| $rc = new ReflectionFunction($closure); | ||
| var_dump($rc->getAttributes()[0]->newInstance()); | ||
| var_dump($rc->isDeprecated()); | ||
|
|
||
| $closure = $foo->test(...); | ||
|
|
||
| $rc = new ReflectionFunction($closure); | ||
| var_dump($rc->getAttributes()[0]->newInstance()); | ||
| var_dump($rc->isDeprecated()); | ||
|
|
||
| $closure = Closure::fromCallable('Clazz::test'); | ||
|
|
||
| $rc = new ReflectionFunction($closure); | ||
| var_dump($rc->getAttributes()[0]->newInstance()); | ||
| var_dump($rc->isDeprecated()); | ||
|
|
||
| $closure = Clazz::test(...); | ||
|
|
||
| $rc = new ReflectionFunction($closure); | ||
| var_dump($rc->getAttributes()[0]->newInstance()); | ||
| var_dump($rc->isDeprecated()); | ||
|
|
||
| ?> | ||
| --EXPECTF-- | ||
| object(Deprecated)#%d (2) { | ||
| ["message"]=> | ||
| NULL | ||
| ["since"]=> | ||
| NULL | ||
| } | ||
| bool(true) | ||
| object(Deprecated)#%d (2) { | ||
| ["message"]=> | ||
| NULL | ||
| ["since"]=> | ||
| NULL | ||
| } | ||
| bool(true) | ||
| object(Deprecated)#%d (2) { | ||
| ["message"]=> | ||
| string(18) "due to some reason" | ||
| ["since"]=> | ||
| NULL | ||
| } | ||
| bool(true) | ||
| object(Deprecated)#%d (2) { | ||
| ["message"]=> | ||
| string(18) "due to some reason" | ||
| ["since"]=> | ||
| NULL | ||
| } | ||
| bool(true) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand, why I do not need to increase the refcount here: If I do, I get a leak.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callisn't a trampoline, and the functioncallis freed inzend_closure_free_storage. The attributes are ignored byzend_closure_free_storage. So you're counting on that the attributes of the original function outlive the closure instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I actually wonder why we refcount the attributes for trampolines in the first place. They always come from a real function, and real functions should outlive trampolines I think. Maybe I'm missing something...
EDIT: I'm running the test suite now with refcounting removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to work fine.