Fix #[\Deprecated] for __call() and __callStatic()
#17592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
reviewed
Jan 27, 2025
TimWolla
force-pushed
the
deprecated-magic-call
branch
from
321bcde to
22dc09c
Compare
iluuu1994
reviewed
Jan 27, 2025
iluuu1994
reviewed
Jan 27, 2025
dstogov
approved these changes
Jan 27, 2025
TimWolla
added a commit
that referenced
this pull request
Jan 27, 2025
* PHP-8.4: Fix `#[\Deprecated]` for `__call()` and `__callStatic()` (#17592)
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Feb 21, 2025
…4.3 to 8.4.4 This regressed in phpGH-17592. The function is with its attributes HashTable* is copied in zend_get_closure_invoke_method() but its refcount is not increased. This caused a crash in the Symfony demo page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-17597.
/cc @beberlei