-
Notifications
You must be signed in to change notification settings - Fork 7.9k
getaddrinfo conversion #15555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NattyNarwhal
wants to merge
17
commits into
php:master
Choose a base branch
from
NattyNarwhal:gai-conversion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
getaddrinfo conversion #15555
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
005addf
Convert gethostbyname(l) to use getaddrinfo
NattyNarwhal d5b3cfe
Add php_network_getaddresses_ex
NattyNarwhal b7b5028
Convert sockaddr_conv.c to use getaddrinfo for v4
NattyNarwhal 84b8214
Convert fastcgi listen to use getaddrinfo
NattyNarwhal 5dcd076
Provide function for resolving a single address
NattyNarwhal c8d649e
Don't bother storing the gai_strerror result
NattyNarwhal 68d1e19
Convert php_open_listen_sock to use getaddrinfo
NattyNarwhal 6253129
Remove remnant of refactor
NattyNarwhal 8556fdf
Convert sockaddr conv to use bool
NattyNarwhal 16cd84a
Remove getaddrinfo->gethostbyname fallback
NattyNarwhal 41c590b
Remove gethostbyname from ABI (mostly)
NattyNarwhal c4efccd
Convert php_network_getaddress* to use unsigned size_t
NattyNarwhal b6c219b
Clean up remaining gethostbyname(_r) detritus
NattyNarwhal 500f68c
gai_strerror will return differently per platform
NattyNarwhal 8fb9002
getaddrinfo emits warnings now for failures to resolve
NattyNarwhal 3dbfdf5
Remove old file submodule dtor
NattyNarwhal 7267213
Actually use the returned value
NattyNarwhal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ curl | |
--SKIPIF-- | ||
<?php | ||
$addr = "www.".uniqid().".".uniqid(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Surely we could try to come up with something that we know does not exist? Like a weird subdomain name of |
||
if (gethostbyname($addr) != $addr) { | ||
if (@gethostbyname($addr) != $addr) { | ||
print "skip catch all dns"; | ||
} | ||
?> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.