Skip to content

Update extension skeleton .gitignore #15542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

zeriyoshi
Copy link
Contributor

Update .gitignore in ext/skeleton to exclude additional auto-generated files

The .gitignore file in ext/skeleton is not excluding some auto-generated files.

@Girgias Girgias requested a review from petk August 22, 2024 11:45
Co-authored-by: Peter Kokot <[email protected]>
config.log
config.nice
config.status
config.sub
configure
configure~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed after *~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was on mobile and missed it.

@@ -8,11 +9,13 @@ build
config.guess
config.h
config.h.in
*~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps if we add this one on top somewhere together with those *.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked sorted, so I added it to the bottom of the list.

Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you @zeriyoshi

@petk petk merged commit 0c73553 into php:master Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants