-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update extension skeleton .gitignore #15542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Peter Kokot <[email protected]>
ext/skeleton/.gitignore.in
Outdated
config.log | ||
config.nice | ||
config.status | ||
config.sub | ||
configure | ||
configure~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed after *~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I was on mobile and missed it.
ext/skeleton/.gitignore.in
Outdated
@@ -8,11 +9,13 @@ build | |||
config.guess | |||
config.h | |||
config.h.in | |||
*~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps if we add this one on top somewhere together with those *.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looked sorted, so I added it to the bottom of the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you @zeriyoshi
Update .gitignore in ext/skeleton to exclude additional auto-generated files
The .gitignore file in ext/skeleton is not excluding some auto-generated files.