Skip to content

Autotools: Fix stack direction check #15528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

petk
Copy link
Member

@petk petk commented Aug 21, 2024

On Solaris 10 and GCC 4.9 this check failed with error in config.log: error: missing binary operator before token "("

The __has_builtin must be checked in its own #if. Is this correct?

On Solaris 10 and GCC 4.9 this check failed with error in config.log:
error: missing binary operator before token "("

The __has_builtin must be checked in its own `#if`.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lctm

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know how these work, but if this fixes the issue then this is fine

@petk
Copy link
Member Author

petk commented Aug 21, 2024

Ok, thanks. Yes, this #if defined __has_builtin needs to be done like this because compiler cannot process that check:
https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005fbuiltin.html

However, there is one more in ext/date/timelib like this but it doesn't cause error...

@petk
Copy link
Member Author

petk commented Aug 21, 2024

I've appended also a bit of CS fixes here so the test program is a bit simpler to read.

@petk petk merged commit 6b809c8 into php:master Aug 21, 2024
9 of 10 checks passed
@petk petk deleted the patch-solaris-10-ZEND_CHECK_STACK_DIRECTION branch August 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants