Skip to content

Fix comments in win32/sendmail.c #15326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Aug 10, 2024

These use a mixed style of block and line comments, and clang warns about this (-Wcomment), so we fix that.


Note that these are the only comments that cause -Wcomment warnings for a full build of all self contained extensions (except for com_dotnet).

I don't mind keeping these banners (might still be useful when developing with notepad.exe), but we should fix the mixed comment style.

These use a mixed style of block and line comments, and clang warns
about this (`-Wcomment`), so we fix that.
@cmb69 cmb69 merged commit d98c4b6 into php:master Aug 10, 2024
10 checks passed
@cmb69 cmb69 deleted the cmb/sendmail-comments branch August 10, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants