Support somewhat recent clang versions on Windows #15324
Conversation
Prior to clang 10.0.0, `clang-cl -v` apparently always appended some fine grained version information in parentheses[1]; this is no longer the case, so the build fails early because the compiler version could not be detected. Since we never used this fine grained version info, we no longer check for it. As of clang 13.0.0, the `/fallback` command option has been removed[2], so we only set the flag for older clang versions. [1] <php#11313 (comment)> [2] <https://releases.llvm.org/13.0.0/tools/clang/docs/ReleaseNotes.html#removed-compiler-flags>
|
Note that all compilation errors with clang 18.1.8 (default configuration; full x64 snapshot build with all dependencies) have been fixed (PR #15329 is pending, but approved), except for a typedef redifinition (signed char vs. char) in the SNMP headers, but this library should be updated anyway. |
|
Oh, I've noticed that there are related issues regarding And not necessarily related: UBSan appears to broken; for standalone clang 18.1.8 it seems to report bogus undefined behavior when running |
|
Ah I read the code and tested it before I saw your latest message. Didn't check ubsan & co. |
|
No problem. We can merge this, and work on sanitizer support in another PR. :) I'm already happy to be able to build with clang on Windows for the better (or more intuitive) errors/warnings. MSVC error codes are not nice to handle. Working ASan and UBSan support would be the icing on the cake. |
|
Agreed. |
Prior to clang 10.0.0,
clang-cl -vapparently always appended some fine grained version information in parentheses[1]; this is no longer the case, so the build fails early because the compiler version could not be detected. Since we never used this fine grained version info, we no longer check for it.As of clang 13.0.0, the
/fallbackcommand option has been removed[2], so we only set the flag for older clang versions.[1] #11313 (comment)
[2] https://releases.llvm.org/13.0.0/tools/clang/docs/ReleaseNotes.html#removed-compiler-flags
With these changes I've managed to have a successful minimal build (
--with-toolset=clang --disable-all --enable-cli) with clang 18.1.8 on x64 Windows (didn't try x86 so far), if I setCFLAGS=-Wno-implicit-function-declaration. I'm going to follow up with a patch for the undeclared functions.