Update gd extension preprocessor macros help texts #15296
Conversation
PHP_GD_CHECK_FORMAT macro 2nd argument is changed from automatic AC_DEFINE_UNQUOTED to manual action for easier usage.
| [AC_DEFINE([HAVE_GD_GET_INTERPOLATION], [1], | ||
| [Define to 1 if GD library has the 'gdImageGetInterpolationMethod' | ||
| function.])], |
There was a problem hiding this comment.
Nice. gdImageGetInterpolationMethod() is available as of libgd 2.1.1; do we still support such old versions?
However, not really related to this PR; just mentioning.
There was a problem hiding this comment.
can be merged as is however centos 8 libgd version is 2.2.5. can be addressed in another PR eventually.
There was a problem hiding this comment.
I'm all in favor of bumping the libgd minimum version however issue is that bundled libgd is of version ~2.0.35. Probably adjusted already to a partially newer version. But it doesn't have the gdImageGetInterpolationMethod as an exported function yet.
There was a problem hiding this comment.
bundled libgd is of version ~2.0.35
Yeah, that is bad. There is special support for this, so it claims to be 2.1.0 compatible, but that is also wrong. In fact it is closer to 2.2 or likely even 2.3, although it is certainly not fully compatible with any system libgd. Long time ago I suggested to update the bundled GD version numbers/string, but that was rejected because the goal was to drop bundled GD – but that still didn't happen.
Anyway, we can resolve this in another PR, and just ignore this for this PR.
| AC_DEFINE('HAVE_XPM', 1, "Define to 1 if you have the xpm library."); | ||
| AC_DEFINE('HAVE_GD_XPM', 1, "Define to 1 if gd extension has XPM support."); | ||
| AC_DEFINE('HAVE_LIBFREETYPE', 1, "Define to 1 if you have the FreeType library."); | ||
| AC_DEFINE('HAVE_GD_FREETYPE', 1, "Define to 1 if gd extension has FreeType support."); |
There was a problem hiding this comment.
Oh, I thought that the bundled libgd also has JIT-mapped Japanese font support on Windows, but apparently not. For better compatibility with system libgd, we may consider to add that; on the other hand, this is a feature which always looked somewhat arbitrary to me – why not have that for other character encodings, too. Or maybe better, why not leave converting to UTF-8 up to users?
Anyhow, again unrelated to the PR at hand.
PHP_GD_CHECK_FORMAT macro 2nd argument is changed from automatic AC_DEFINE_UNQUOTED to manual action for easier usage.