random: Use CSPRNG for CombinedLCG seeding

[TimWolla]

Now that the CombinedLCG is no longer used within GENERATE_SEED(), we can safely use the CSPRNG with a php_random_generate_fallback_seed() fallback to seed the CombinedLCG.

[zeriyoshi]

I believe this is not a problem, but it might be a good idea to interview active extension users to avoid confusion like we had with MT before.

[TimWolla]

to avoid confusion like we had with MT before.

Can you clarify what confusion you are referring to?

---

For the CombinedLCG: It is not seedable from userland and the seeding strategy in php_random_combinedlcg_seed_default should not be externally observable. It even includes a fallback for the rare case where the CSPRNG fails. So this should be a 100 % safe change.

[zeriyoshi]

to avoid confusion like we had with MT before.

Can you clarify what confusion you are referring to?

For the CombinedLCG: It is not seedable from userland and the seeding strategy in php_random_combinedlcg_seed_default should not be externally observable. It even includes a fallback for the rare case where the CSPRNG fails. So this should be a 100 % safe change.

Sorry. The intonation of the words was incorrect. It was not meant to be a mast, but only a reminder to those who saw my comment.

I don't see a problem either. I searched for such an extension on GitHub just to be sure, but I don't seem to find one. No problem!

[TimWolla]

It was not meant to be a mast, but only a reminder to those who saw my comment.

Sorry, I don't follow here. I don’t believe “mast” is the English word you wanted to use here.

---

Anyway, merging as you confirmed this looks good to you!