Skip to content

CI: update freebsd 13 image. #13622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Mar 7, 2024

13.2 is going to be EOL.

@devnexen devnexen requested a review from iluuu1994 March 7, 2024 21:16
@iluuu1994
Copy link
Member

Hmm, the build looks stuck.

image

@devnexen
Copy link
Member Author

Hmm, the build looks stuck.

Finally it was a test using proc_open. Now, I recall FreeBSD had issue with it in the past but for now it is disabled.
Let me know what you think when you have the chance.

@@ -14,7 +14,7 @@ freebsd_task:
- pkg install -y autoconf bison gmake re2c icu libiconv png freetype2 enchant2 bzip2 krb5 t1lib gmp tidyp libsodium libzip libxml2 libxslt openssl oniguruma pkgconf webp libavif
script:
- ./buildconf -f
- ./configure --prefix=/usr/local --enable-debug --enable-option-checking=fatal --enable-fpm --with-pdo-sqlite --without-pear --with-bz2 --with-avif --with-jpeg --with-webp --with-freetype --enable-gd --enable-exif --with-zip --with-zlib --enable-soap --enable-xmlreader --with-xsl --with-libxml --enable-shmop --enable-pcntl --enable-mbstring --with-curl --enable-sockets --with-openssl --with-iconv=/usr/local --enable-bcmath --enable-calendar --enable-ftp --with-kerberos --with-ffi --enable-zend-test --enable-dl-test=shared --enable-intl --with-mhash --with-sodium --enable-werror --with-config-file-path=/etc --with-config-file-scan-dir=/etc/php.d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--enable-werror shoulud be re-added if possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I m afraid it leads to some code changes ... I would suggest to either use another compiler than the system one (which is clang 17) e.g. clang 15 or dropping this setting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are ok, is it many? I suppose this is ok, given that we have warnings enabled for the other jobs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to re-enable it in master after merging 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are ok, is it many? I suppose this is ok, given that we have warnings enabled for the other jobs.

The bundled libbcmath is already a "mess" by itself, but even removing it there is other extensions involved like ffi ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then let's re-add the flag for master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I merge it you think now ?

.cirrus.yml Outdated
@@ -25,4 +25,4 @@ freebsd_task:
tests_script:
- export SKIP_IO_CAPTURE_TESTS=1
- export CI_NO_IPV6=1
- sapi/cli/php run-tests.php -P -q -j2 -g FAIL,BORK,LEAK,XLEAK --no-progress --offline --show-diff --show-slow 1000 --set-timeout 120 -d zend_extension=opcache.so
- sapi/cli/php run-tests.php -P -q -j2 -g FAIL,BORK,LEAK,XLEAK --offline --show-diff --show-slow 1000 --set-timeout 120 -d zend_extension=opcache.so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with --no-progress.

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @devnexen!

@devnexen devnexen closed this in f2f656c Mar 19, 2024
devnexen added a commit that referenced this pull request Mar 19, 2024
13.2 is going to be EOL.

close GH-13622
cmb69 pushed a commit to cmb69/php-src that referenced this pull request Nov 15, 2024
13.2 is going to be EOL.

close phpGH-13622

(cherry picked from commit f2f656c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants