Remove nsl library check in sapi/fpm #13478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In sapi/fpm the inet_ntop is used instead of the deprecated inet_addr and the required library, if needed, is linked from the configure.ac.
devnexen
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sapi/fpm the inet_ntop is used instead of the deprecated inet_addr and the required library, if needed, is linked from the configure.ac.
Otherwise, I'll probably also recheck the libraries appended in the configure.ac again in the next PRs, because they need to be slightly synced for the
inet_ntopandinet_ptonusage across the php-src. Currently they rely on other library checks, but that is a separate issue from the sapi/fpm.