Create modules directory in a centralized location #13411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
approved these changes
Feb 16, 2024
|
I'll add some more changes here to make it a bit more robust. Sorry, I've missed it before opening the PR. That phplibdir variable shouldn't change the value during the configuration... |
petk
force-pushed
the
patch-modules-dir
branch
from
e4197bb to
2c65dea
Compare
Shared objects of extensions during the *nix build are copied to the `modules` directory. It is a practice established since the early days of the PHP build system. Other build systems may have similar concept of "library destination directory". On Windows, they are put into the root build directory. Such directory simplifies collection of the shared extensions during testing, or when running the cli executable at the end of the build process. This change ensures that the directory is consistently created in a single location, for both the primary PHP build process and when utilizing `phpize` within community extensions. The AC_CONFIG_COMMANDS_PRE is executed at the end of the configuration phase, before creating the config.status script, where also build directories and global Makefile are created. The pwd is executed using the recommended $(...) instead of the obsolete backticks. Autoconf automatically locates the proper shell and re-executes the configure script if such case is found that $(...) is not supported (the initial /bin/sh on Solaris 10, for example).
|
This one is now ready. Details are in the Git commit message. Build tested with in-source, out-of-source, phpized in-source and out-of-source. I'll merged it in the following days if everyone is fine with this. cc @devnexen |
|
Merged to master. In case anything interfering is found, I'll add further patches, but I don't expect any issues here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared objects of extensions during the build are copied to the
modulesdirectory. It is a practice established since the early days of the PHP build system. This change ensures that the directory is consistently created in a single location, for both the primary PHP build process and when utilizingphpizewithin extensions. For now, the shtool is still utilized, until it can be clear that it is obsolete on current systems and their shells in favor of the native mkdir.