[RFC] Add a way to opt-in ext/dom spec compliance #13031

nielsdos · 2023-12-26T16:47:31Z

RFC: https://wiki.php.net/rfc/opt_in_dom_spec_compliance

In short: this PR aims to fix all the spec bugs in ext/dom. It does so in a backwards compatible way. This means that existing PHP code will keep working and not notice any changes. When the developer uses the new DOM\XMLDocument and DOM\HTMLDocument classes that I introduced in https://wiki.php.net/rfc/domdocument_html5_parser then the DOM extension switches to a "spec compliant" mode.

This gets rid of many issues that have been plaguing the DOM extension since forever and fixes many bugs that are otherwise unfixable.

What's missing in the current implementation is fixes to the property/method types. For example, the fact that DOM\Node::$prefix returns the empty string instead of NULL when no prefix is set (and more of course, this is just an example).

ext/dom/text.c

Girgias · 2024-03-07T21:41:19Z

ext/dom/xml_document.c

-			if (mode == DOM_LOAD_FILE) {
-				zend_throw_exception_ex(NULL, 0, "Cannot open file '%s'", source);
+			if (lxml_doc == DOM_DOCUMENT_MALFORMED) {
+				zend_throw_exception_ex(NULL, 0, "XML document is malformed");


Should this throw a DOM/XML specific Exception?

There will already have been warnings from libxml; and I don't think any of the DOMException types fit here (see domexception.h/c).

ext/dom/xml_serializer.c

ext/dom/parentnode.c

ext/dom/php_dom.c

Girgias

I think we are nearly there

Girgias · 2024-03-08T21:04:33Z

ext/dom/element.c

+	bool should_free_result;
+	const xmlChar *result = dom_get_attribute_ns(intern, elemp, uri, uri_len, name, &should_free_result);


Ah seems this hasn't been done yet

ext/dom/element.c

ext/dom/php_dom.stub.php

ext/dom/php_dom.c

Girgias

Well, I think this as good as a review that I'll be able to do.

Thanks for the work!

This reverts commit f0af56f.

drupol · 2024-03-14T18:19:52Z

Hey hi !

I think this PR breaks master branch, here's the compilation log:

error: builder for '/nix/store/8igfr14c7bcbypdsr0pfp4hh3d84gp1c-php-xsl-8.4.999-c2d20f4.drv' failed with exit code 2;
       last 25 log lines:
       >    26 | #include "ext/dom/php_dom.h"
       >       |          ^~~~~~~~~~~~~~~~~~~
       > compilation terminated.
       > make: *** [Makefile:212: xsltprocessor.lo] Error 1
       > make: *** Waiting for unfinished jobs....
       > In file included from /build/source/ext/xsl/php_xsl.c:24:
       > /build/source/ext/xsl/php_xsl.h:61:9: error: unknown type name 'php_dom_xpath_callbacks'
       >    61 |         php_dom_xpath_callbacks xpath_callbacks;
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/php_xsl.c: In function 'xsl_objects_get_gc':
       > /build/source/ext/xsl/php_xsl.c:59:16: warning: implicit declaration of function 'php_dom_xpath_callbacks_get_gc_for_whole_object' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
       >    59 |         return php_dom_xpath_callbacks_get_gc_for_whole_object(&intern->xpath_callbacks, object, table, n);
       >       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/php_xsl.c:59:16: warning: returning 'int' from a function with return type 'HashTable *' {aka 'struct _zend_array *'} makes pointer from integer without a cast [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wint-conversion-Wint-conversion8;;]
       >    59 |         return php_dom_xpath_callbacks_get_gc_for_whole_object(&intern->xpath_callbacks, object, table, n);
       >       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/php_xsl.c: In function 'xsl_objects_free_storage':
       > /build/source/ext/xsl/php_xsl.c:89:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_dtor' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
       >    89 |         php_dom_xpath_callbacks_dtor(&intern->xpath_callbacks);
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/php_xsl.c: In function 'xsl_objects_new':
       > /build/source/ext/xsl/php_xsl.c:119:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_ctor' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
       >   119 |         php_dom_xpath_callbacks_ctor(&intern->xpath_callbacks);
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > make: *** [Makefile:209: php_xsl.lo] Error 1
       For full logs, run 'nix log /nix/store/8igfr14c7bcbypdsr0pfp4hh3d84gp1c-php-xsl-8.4.999-c2d20f4.drv'.

nielsdos · 2024-03-14T18:54:26Z

@drupol ext/xsl has a dependency on DOM, for some reason it can't find the ext/dom/php_dom.h file. I don't know how the Nix build system works, but here it works fine.

The only thing I spot, but this is also true for older branches, is that I don't see an explicit dependency added in the config.m4, which the following patch should resolve:

diff --git a/ext/xsl/config.m4 b/ext/xsl/config.m4
index 14af536fa7..8d45e8eacb 100644
--- a/ext/xsl/config.m4
+++ b/ext/xsl/config.m4
@@ -29,4 +29,5 @@ if test "$PHP_XSL" != "no"; then
   PHP_NEW_EXTENSION(xsl, php_xsl.c xsltprocessor.c, $ext_shared)
   PHP_SUBST(XSL_SHARED_LIBADD)
   PHP_ADD_EXTENSION_DEP(xsl, libxml)
+  PHP_ADD_EXTENSION_DEP(xsl, dom)
 fi

but given that this has been wrong for years, it probably does not explain your build problem.

drupol · 2024-03-14T19:35:04Z

Thanks Niels,

I applied your patch and rebuild, with the very last commit:

php-xsl>  gcc -I. -I/build/source/ext/xsl -I/build/source/ext/xsl/main -I/build/source/ext/xsl -I/nix/store/rjpf1ac2sph9pifgk94bsdz8h9bgigx4-php-8.4.999-586153b-dev/include/php -I/nix/store/rjpf1ac2sph9pifgk94bsdz8h9bgigx4-php-8.4.999-586153b-dev/include/php/main -I/nix/store/rjpf1ac2sph9pifgk94bsdz8h9bgigx4-php-8.4.999-586153b-dev/include/php/TSRM -I/nix/store/rjpf1ac2sph9pifgk94bsdz8h9bgigx4-php-8.4.999-586153b-dev/include/php/Zend -I/nix/store/rjpf1ac2sph9pifgk94bsdz8h9bgigx4-php-8.4.999-586153b-dev/include/php/ext -I/nix/store/rjpf1ac2sph9pifgk94bsdz8h9bgigx4-php-8.4.999-586153b-dev/include/php/ext/date/lib -I/nix/store/b84k136qa0q00r0wipazh99v4j4nhr27-libxslt-1.1.39-dev/include -I/nix/store/pn27sbss40whpcvkzcb36g5nzj71d64s-libxml2-2.12.5-dev/include/libxml2 -DHAVE_CONFIG_H -g -O2 -D_GNU_SOURCE -DZEND_COMPILE_DL_EXT=1 -c /build/source/ext/xsl/php_xsl.c -MMD -MF php_xsl.dep -MT php_xsl.lo  -fPIC -DPIC -o .libs/php_xsl.o
php-xsl> In file included from /build/source/ext/xsl/xsltprocessor.c:23:
php-xsl> /build/source/ext/xsl/php_xsl.h:61:9: error: unknown type name 'php_dom_xpath_callbacks'
php-xsl>    61 |         php_dom_xpath_callbacks xpath_callbacks;
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~
php-xsl> In file included from /build/source/ext/xsl/php_xsl.c:24:
php-xsl> /build/source/ext/xsl/php_xsl.h:61:9: error: unknown type name 'php_dom_xpath_callbacks'
php-xsl>    61 |         php_dom_xpath_callbacks xpath_callbacks;
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~
php-xsl> In file included from /build/source/ext/xsl/xsltprocessor.c:26:
php-xsl> /build/source/ext/xsl/ext/dom/php_dom.h:68:9: error: unknown type name 'php_dom_xpath_callbacks'
php-xsl>    68 |         php_dom_xpath_callbacks xpath_callbacks;
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:94:76: error: unknown type name 'php_dom_xpath_nodeset_evaluation_mode'
php-xsl>    94 | static void xsl_ext_function_php(xmlXPathParserContextPtr ctxt, int nargs, php_dom_xpath_nodeset_evaluation_mode evaluation_mode) /* {{{ */
php-xsl>       |                                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/php_xsl.c: In function 'xsl_objects_get_gc':
php-xsl> /build/source/ext/xsl/php_xsl.c:59:16: warning: implicit declaration of function 'php_dom_xpath_callbacks_get_gc_for_whole_object' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>    59 |         return php_dom_xpath_callbacks_get_gc_for_whole_object(&intern->xpath_callbacks, object, table, n);
php-xsl>       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/php_xsl.c:59:16: warning: returning 'int' from a function with return type 'HashTable *' {aka 'struct _zend_array *'} makes pointer from integer without a cast [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wint-conversion-Wint-conversion8;;]
php-xsl>    59 |         return php_dom_xpath_callbacks_get_gc_for_whole_object(&intern->xpath_callbacks, object, table, n);
php-xsl>       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c: In function 'xsl_ext_function_string_php':
php-xsl> /build/source/ext/xsl/xsltprocessor.c:107:9: warning: implicit declaration of function 'xsl_ext_function_php'; did you mean 'xsl_ext_function_object_php'? [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   107 |         xsl_ext_function_php(ctxt, nargs, PHP_DOM_XPATH_EVALUATE_NODESET_TO_STRING);
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~
php-xsl>       |         xsl_ext_function_object_php
php-xsl> /build/source/ext/xsl/php_xsl.c: In function 'xsl_objects_free_storage':
php-xsl> /build/source/ext/xsl/php_xsl.c:89:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_dtor' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>    89 |         php_dom_xpath_callbacks_dtor(&intern->xpath_callbacks);
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/php_xsl.c: In function 'xsl_objects_new':
php-xsl> /build/source/ext/xsl/php_xsl.c:119:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_ctor' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   119 |         php_dom_xpath_callbacks_ctor(&intern->xpath_callbacks);
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:107:43: error: 'PHP_DOM_XPATH_EVALUATE_NODESET_TO_STRING' undeclared (first use in this function)
php-xsl>   107 |         xsl_ext_function_php(ctxt, nargs, PHP_DOM_XPATH_EVALUATE_NODESET_TO_STRING);
php-xsl>       |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:107:43: note: each undeclared identifier is reported only once for each function it appears in
php-xsl> make: *** [Makefile:209: php_xsl.lo] Error 1
php-xsl> make: *** Waiting for unfinished jobs....
php-xsl> /build/source/ext/xsl/xsltprocessor.c: In function 'xsl_ext_function_object_php':
php-xsl> /build/source/ext/xsl/xsltprocessor.c:113:43: error: 'PHP_DOM_XPATH_EVALUATE_NODESET_TO_NODESET' undeclared (first use in this function)
php-xsl>   113 |         xsl_ext_function_php(ctxt, nargs, PHP_DOM_XPATH_EVALUATE_NODESET_TO_NODESET);
php-xsl>       |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c: In function 'xsl_ext_function_trampoline':
php-xsl> /build/source/ext/xsl/xsltprocessor.c:121:17: warning: implicit declaration of function 'php_dom_xpath_callbacks_clean_argument_stack' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   121 |                 php_dom_xpath_callbacks_clean_argument_stack(ctxt, nargs);
php-xsl>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:123:17: warning: implicit declaration of function 'php_dom_xpath_callbacks_call_custom_ns' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   123 |                 php_dom_xpath_callbacks_call_custom_ns(&intern->xpath_callbacks, ctxt, nargs, PHP_DOM_XPATH_EVALUATE_NODESET_TO_NODESET, (dom_object *) intern->doc, xsl_proxy_factory);
php-xsl>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:123:95: error: 'PHP_DOM_XPATH_EVALUATE_NODESET_TO_NODESET' undeclared (first use in this function)
php-xsl>   123 |                 php_dom_xpath_callbacks_call_custom_ns(&intern->xpath_callbacks, ctxt, nargs, PHP_DOM_XPATH_EVALUATE_NODESET_TO_NODESET, (dom_object *) intern->doc, xsl_proxy_factory);
php-xsl>       |                                                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c: In function 'php_xsl_apply_stylesheet':
php-xsl> /build/source/ext/xsl/xsltprocessor.c:399:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_delayed_lib_registration' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   399 |         php_dom_xpath_callbacks_delayed_lib_registration(&intern->xpath_callbacks, ctxt, php_xsl_delayed_lib_registration);
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:417:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_clean_node_list' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   417 |         php_dom_xpath_callbacks_clean_node_list(&intern->xpath_callbacks);
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c: In function 'zim_XSLTProcessor_registerPHPFunctions':
php-xsl> /build/source/ext/xsl/xsltprocessor.c:682:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_update_method_handler' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   682 |         php_dom_xpath_callbacks_update_method_handler(
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:688:17: error: 'PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NULLS' undeclared (first use in this function)
php-xsl>   688 |                 PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NULLS,
php-xsl>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c: In function 'zim_XSLTProcessor_registerPHPFunctionNS':
php-xsl> /build/source/ext/xsl/xsltprocessor.c:713:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_update_single_method_handler' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
php-xsl>   713 |         php_dom_xpath_callbacks_update_single_method_handler(
php-xsl>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> /build/source/ext/xsl/xsltprocessor.c:719:17: error: 'PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NCNAME' undeclared (first use in this function)
php-xsl>   719 |                 PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NCNAME,
php-xsl>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
php-xsl> make: *** [Makefile:212: xsltprocessor.lo] Error 1
error: builder for '/nix/store/g159zzyjy5naw6k2n1376k7spk5r2cng-php-xsl-8.4.999-586153b.drv' failed with exit code 2;
       last 25 log lines:
       > /build/source/ext/xsl/xsltprocessor.c:123:95: error: 'PHP_DOM_XPATH_EVALUATE_NODESET_TO_NODESET' undeclared (first use in this function)
       >   123 |                 php_dom_xpath_callbacks_call_custom_ns(&intern->xpath_callbacks, ctxt, nargs, PHP_DOM_XPATH_EVALUATE_NODESET_TO_NODESET, (dom_object *) intern->doc, xsl_proxy_factory);
       >       |                                                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/xsltprocessor.c: In function 'php_xsl_apply_stylesheet':
       > /build/source/ext/xsl/xsltprocessor.c:399:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_delayed_lib_registration' [-Wimplicit-function-declaration]
       >   399 |         php_dom_xpath_callbacks_delayed_lib_registration(&intern->xpath_callbacks, ctxt, php_xsl_delayed_lib_registration);
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/xsltprocessor.c:417:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_clean_node_list' [-Wimplicit-function-declaration]
       >   417 |         php_dom_xpath_callbacks_clean_node_list(&intern->xpath_callbacks);
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/xsltprocessor.c: In function 'zim_XSLTProcessor_registerPHPFunctions':
       > /build/source/ext/xsl/xsltprocessor.c:682:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_update_method_handler' [-Wimplicit-function-declaration]
       >   682 |         php_dom_xpath_callbacks_update_method_handler(
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/xsltprocessor.c:688:17: error: 'PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NULLS' undeclared (first use in this function)
       >   688 |                 PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NULLS,
       >       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/xsltprocessor.c: In function 'zim_XSLTProcessor_registerPHPFunctionNS':
       > /build/source/ext/xsl/xsltprocessor.c:713:9: warning: implicit declaration of function 'php_dom_xpath_callbacks_update_single_method_handler' [-Wimplicit-function-declaration]
       >   713 |         php_dom_xpath_callbacks_update_single_method_handler(
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/ext/xsl/xsltprocessor.c:719:17: error: 'PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NCNAME' undeclared (first use in this function)
       >   719 |                 PHP_DOM_XPATH_CALLBACK_NAME_VALIDATE_NCNAME,
       >       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > make: *** [Makefile:212: xsltprocessor.lo] Error 1
       For full logs, run 'nix log /nix/store/g159zzyjy5naw6k2n1376k7spk5r2cng-php-xsl-8.4.999-586153b.drv'.

nielsdos · 2024-03-14T19:50:06Z

@drupol I don't understand the Nix build system, but I think that for some reason HAVE_DOM is not defined.

@nielsdos

see comments from @nielsdos at php/php-src#13031

drupol · 2024-03-14T20:26:09Z

Indeed, setting the var HAVE_DOM fixes it! Submitting a PR for the upcoming PHP version.

drupol · 2024-03-14T20:31:41Z

@drupol I don't understand the Nix build system, but I think that for some reason HAVE_DOM is not defined.

I'll be glad to tell you more in a visio at your best convenience!

mvorisek · 2024-03-20T08:40:03Z

I think this PR breaks master branch, here's the compilation log:

I have the same issue, reported as #13764.

github-actions bot added Category: Build System Extension: dom Extension: libxml labels Dec 26, 2023

nielsdos added the RFC label Dec 26, 2023

nielsdos force-pushed the dom-spec-compliance-pub branch from ff1e704 to a20c0e9 Compare December 28, 2023 22:05

nielsdos mentioned this pull request Dec 31, 2023

DOMDocument::savexml and friends ommit xmlns="" declaration for null namespace, creating incorrect xml representation of the DOM #11404

Closed

nielsdos force-pushed the dom-spec-compliance-pub branch 3 times, most recently from fad5375 to 2c41dc7 Compare January 24, 2024 19:23

nielsdos force-pushed the dom-spec-compliance-pub branch 2 times, most recently from b27984b to e2a9ea5 Compare January 27, 2024 21:51

nielsdos force-pushed the dom-spec-compliance-pub branch 3 times, most recently from 839a918 to b09690d Compare February 8, 2024 18:58

This comment was marked as resolved.

Sign in to view

nielsdos force-pushed the dom-spec-compliance-pub branch 2 times, most recently from ad5cb06 to 495c80b Compare February 10, 2024 16:28

github-actions bot added the Extension: simplexml label Feb 10, 2024

nielsdos force-pushed the dom-spec-compliance-pub branch 6 times, most recently from 1e0de69 to 371a6c7 Compare February 17, 2024 15:56

nielsdos force-pushed the dom-spec-compliance-pub branch from 371a6c7 to 2bab732 Compare February 19, 2024 18:56

veewee mentioned this pull request Feb 20, 2024

Investigate new PHP 84 DOM features veewee/xml#72

Closed

5 tasks

nielsdos force-pushed the dom-spec-compliance-pub branch from 2bab732 to 6dd522a Compare February 23, 2024 21:02

github-actions bot added the Extension: xsl label Feb 24, 2024

nielsdos added 2 commits March 7, 2024 21:48

TEMPORARILY collapse test files so that GH UI doesn't break

f0af56f

Review comments part 1

b2a7b78

Girgias reviewed Mar 7, 2024

View reviewed changes

nielsdos mentioned this pull request Mar 8, 2024

HTMLDocument::saveHTML returns $node’s inner HTML rather than outer HTML #13631

Closed

Review fixes

27efef4

Girgias reviewed Mar 8, 2024

View reviewed changes

nielsdos added 3 commits March 8, 2024 22:33

Initialize should_free_result to false instead everywhere

422595c

Implement numeric string handling for new DOM named dimension

42168a2

Also numeric string handling for NodeList

4afad64

Girgias approved these changes Mar 8, 2024

View reviewed changes

nielsdos added 8 commits March 9, 2024 15:07

Get rid of tentative returns

da46be3

Revert "TEMPORARILY collapse test files so that GH UI doesn't break"

934f797

This reverts commit f0af56f.

Extend test for bug47847

d5e6934

NEWS UPGRADING etc

7956d50

Fix test formatting

e0b520e

Test extension

922a7d8

Test improvements

7a847b1

Cleanup test

3812d1b

nielsdos merged commit 14b6c98 into php:master Mar 9, 2024

nielsdos mentioned this pull request Mar 9, 2024

DOMAttr unescapes character reference #8388

Closed

drupol added a commit to drupol/nixpkgs that referenced this pull request Mar 14, 2024

php.extensions.xsl: update extension in prevision of next PHP version

c3813b7

see comments from @nielsdos at php/php-src#13031

drupol mentioned this pull request Mar 14, 2024

php.extensions.xsl: update extension in prevision of next PHP version NixOS/nixpkgs#295968

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Add a way to opt-in ext/dom spec compliance #13031

[RFC] Add a way to opt-in ext/dom spec compliance #13031

nielsdos commented Dec 26, 2023 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Girgias Mar 7, 2024

nielsdos Mar 8, 2024

Girgias left a comment

Girgias Mar 8, 2024

Girgias left a comment

drupol commented Mar 14, 2024

nielsdos commented Mar 14, 2024

drupol commented Mar 14, 2024

nielsdos commented Mar 14, 2024

drupol commented Mar 14, 2024

drupol commented Mar 14, 2024

mvorisek commented Mar 20, 2024

		bool should_free_result;
		const xmlChar *result = dom_get_attribute_ns(intern, elemp, uri, uri_len, name, &should_free_result);

[RFC] Add a way to opt-in ext/dom spec compliance #13031

[RFC] Add a way to opt-in ext/dom spec compliance #13031

Conversation

nielsdos commented Dec 26, 2023 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Girgias Mar 7, 2024

Choose a reason for hiding this comment

nielsdos Mar 8, 2024

Choose a reason for hiding this comment

Girgias left a comment

Choose a reason for hiding this comment

Girgias Mar 8, 2024

Choose a reason for hiding this comment

Girgias left a comment

Choose a reason for hiding this comment

drupol commented Mar 14, 2024

nielsdos commented Mar 14, 2024

drupol commented Mar 14, 2024

nielsdos commented Mar 14, 2024

drupol commented Mar 14, 2024

drupol commented Mar 14, 2024

mvorisek commented Mar 20, 2024

nielsdos commented Dec 26, 2023 •

edited

Loading