Fixed HASH/PACKED array inference through MAY_BE_ARRAY_EMPTY flag #12591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Nov 1, 2023
Zend/Optimizer/zend_dump.c
Outdated
| fprintf(stderr, "!"); | ||
| } | ||
| if (MAY_BE_EMPTY_ONLY(info)) { | ||
| fprintf(stderr, "empry "); |
There was a problem hiding this comment.
Suggested change
| fprintf(stderr, "empry "); | |
| fprintf(stderr, "empty "); |
|
I believe the bug is similar to a narrowing bug #10008, for which I have a reduced test case: #10008 (comment) |
|
#10008 has a completely different reason. I hope, I'll fix it soon. |
Thank you Dmitry! |
|
Per #12527 (comment) shouldn't it be landed also in PHP 8.2/8.3? |
In case of no problems with community tests, I plan to back-port this tomorrow or on Monday. |
dstogov
added a commit
that referenced
this pull request
Nov 3, 2023
* PHP-8.2: Backport fix for HASH/PACKED array inference through MAY_BE_ARRAY_EMPTY flag (#12591)
dstogov
added a commit
that referenced
this pull request
Nov 3, 2023
* PHP-8.3: Backport fix for HASH/PACKED array inference through MAY_BE_ARRAY_EMPTY flag (#12591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes GH-12527