Skip to content

Repeat JIT tests #12495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Repeat JIT tests #12495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
35c0183
Add PHPSeclib, Psalm and PHPStan to nightly tests
danog Oct 12, 2023
2813621
Add JIT check
danog Oct 22, 2023
7d0f061
Add infection to testsuite, repeat JIT tests
danog Oct 22, 2023
d8997a5
Repeat windows JIT tests too
danog Oct 22, 2023
ce13272
Merge
danog Oct 22, 2023
7c02611
Merge remote-tracking branch 'origin/master' into test_repeat
danog Oct 23, 2023
5c12927
Fix
danog Nov 11, 2023
8f64c9e
Cleanup
danog Feb 1, 2024
596d31a
Merge remote-tracking branch 'origin/master' into test_repeat
danog Feb 1, 2024
3bdc28b
Bump
danog Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/test-linux/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ runs:
export SKIP_IO_CAPTURE_TESTS=1
export STACK_LIMIT_DEFAULTS_CHECK=1
sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \
${{ inputs.jitType == 'disable' && '' || '--repeat 2' }} \
-d opcache.jit=${{ inputs.jitType }} \
-d opcache.protect_memory=1 \
-d opcache.jit_buffer_size=64M \
Expand Down
1 change: 1 addition & 0 deletions .github/actions/test-macos/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ runs:
export CI_NO_IPV6=1
export STACK_LIMIT_DEFAULTS_CHECK=1
sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \
${{ inputs.jitType == 'disable' && '' || '--repeat 2' }} \
-d opcache.jit=${{ inputs.jitType }} \
-d opcache.protect_memory=1 \
-d opcache.jit_buffer_size=64M \
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/windows/test_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ set OPENSSL_CONF=
rem set SSLEAY_CONF=

rem prepare for OPcache
if "%OPCACHE%" equ "1" set OPCACHE_OPTS=-d opcache.enable=1 -d opcache.enable_cli=1 -d opcache.protect_memory=1 -d opcache.jit_buffer_size=64M -d opcache.jit=tracing
if "%OPCACHE%" equ "1" set OPCACHE_OPTS=-d opcache.enable=1 -d opcache.enable_cli=1 -d opcache.protect_memory=1 -d opcache.jit_buffer_size=64M -d opcache.jit_max_root_traces=100000 -d opcache.jit_max_side_traces=100000 -d opcache.jit_max_exit_counters=100000 -d opcache.jit=tracing --repeat 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I don't think --repeat should be added unless we can make sure it works for all tests, or unless the architecture is already tested without --repeat.


rem prepare for enchant
mkdir %~d0\usr\local\lib\enchant-2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
configuration_parameters: >-
CFLAGS="-fsanitize=undefined,address -DZEND_TRACK_ARENA_ALLOC"
LDFLAGS="-fsanitize=undefined,address"
run_tests_parameters: '--asan'
run_tests_parameters: '--asan --repeat 2'
test_function_jit: false
asan: true
- name: _REPEAT
Expand Down
1 change: 1 addition & 0 deletions ext/standard/tests/dir/bug71542.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Bug #71542 (disk_total_space does not work with relative paths)
--FILE--
<?php
chdir(__DIR__);
$dir = basename(getcwd());
chdir("..");
var_dump(
Expand Down
Loading