Deprecate mysqli_kill #11926
Merged
Deprecate mysqli_kill #11926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same comment as #11929 |
rosier
reviewed
Feb 26, 2024
rosier
reviewed
Feb 26, 2024
|
On this, it seems the functionality isn't deprecated in MariaDB, as far as I can see from a quick search anyway. It doesn't mean it needs to be kept in PHP of course (and if the behaviour will differ based on server version, potentially that is justification for its removal by itself), but it does seem there are some subtle differences between |
|
@kamil-tekiela could you rebase this PR? |
kamil-tekiela
force-pushed
the
Deprecate-mysqli_kill
branch
from
c52f58a to
4512d82
Compare
kamil-tekiela
force-pushed
the
Deprecate-mysqli_kill
branch
from
8abed8e to
9235de7
Compare
Co-authored-by: Jan Rosier <[email protected]>
Co-authored-by: Jan Rosier <[email protected]>
kamil-tekiela
force-pushed
the
Deprecate-mysqli_kill
branch
from
9235de7 to
562f184
Compare
Girgias
reviewed
Aug 9, 2024
You know, I actually didn't see it there. I just run the gen_stub and committed. I'll remove it from this PR. |
kamil-tekiela
force-pushed
the
Deprecate-mysqli_kill
branch
from
562f184 to
346d75b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL 5.7 has deprecated
COM_PROCESS_KILLwhich is used under the hood by mysqli. See:I understand it may be controversial for PHP, but we shouldn't support commands that are deprecated in MySQL. The only problem with this is that the way that PHP tests used this function is actually problematic. When we use
mysqli_killto kill our own process there's no error, but when we use SQLKILLthen we get an error about aborted query. It makes sense, but creates a problematic upgrade path. Not sure if there's a way to deal with this.We could emulate that command in mysqlnd, but that's an undesirable solution.