Fix spec compliance error for DOMDocument::getElementsByTagNameNS #11343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec link: https://dom.spec.whatwg.org/#concept-getelementsbytagnamens Spec says we should match any namespace when '*' is provided. This was however not the case: elements that didn't have a namespace were not returned. This patch fixes the error by modifying the namespace check.
Girgias
reviewed
May 29, 2023
ext/dom/tests/DOMDocument_getElementsByTagNameNS_match_any_namespace.phpt
Show resolved
Hide resolved
ext/dom/php_dom.c
Outdated
Comment on lines
1273
to
1275
| /* Note: The spec says that ns == NULL should change the namespace to the empty string. | ||
| * This is already done at the PHP_FUNCTIONs that create this iterator. | ||
| * The null case here actually means we want to match any namespace instead. */ |
There was a problem hiding this comment.
So a NULL pointer can only happen via an internal call?
And the spec says
If namespace is the empty string, then set it to null.
Which seems to contradict this comment or am I missing something?
There was a problem hiding this comment.
So a NULL pointer can only happen via an internal call?
Yes it can only happen via an internal call.
Which seems to contradict this comment or am I missing something?
Errr oops, I meant to state they are equivalent.
There was a problem hiding this comment.
Okay I rewrote the comment to be more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec link: https://dom.spec.whatwg.org/#concept-getelementsbytagnamens Spec says we should match any namespace when '*' is provided. This was however not the case: elements that didn't have a namespace were not returned. This patch fixes the error by modifying the namespace check.
Discovered while working on GH-11330.