Skip to content

readfile() Windows test file can conflict with another test when run in parrallel #17879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Girgias opened this issue Feb 21, 2025 · 1 comment
Closed

readfile() Windows test file can conflict with another test when run in parrallel #17879

Girgias opened this issue Feb 21, 2025 · 1 comment
Assignees
@cmb69
Labels
Bug Category: Tests Status: Verified

Comments

@Girgias
Copy link
Member

Girgias commented Feb 21, 2025

Description

The following file ext\standard\tests\file\readfile_variation8-win32.phpt sometimes fails CI because warning about existing folder are issued by mkdir().

Can you have a look @cmb69 as you have a Windows machine?

PHP Version

master

Operating System

No response
@cmb69
Copy link
Member

cmb69 commented Feb 21, 2025

php-src/ext/standard/tests/file/readfile_variation9.phpt

Lines 8 to 9 in 7b8a61a

$mainDir = "readfileVar8";
$subDir = "readfileVar8Sub";

cmb69 added a commit to cmb69/php-src that referenced this issue Feb 21, 2025
@cmb69
Fix phpGH-17879: readfile_variation8-win32.phpt test conflict
98a8258 
Apparently a copy and paste issue.
@cmb69 cmb69 linked a pull request Feb 21, 2025 that will close this issue
Fix GH-17879: readfile_variation8-win32.phpt test conflict #17881
Closed
@cmb69 cmb69 closed this as completed in 769f292 Feb 21, 2025
cmb69 added a commit that referenced this issue Feb 21, 2025
@cmb69
Merge branch 'PHP-8.3' into PHP-8.4
2c911e4 
* PHP-8.3:
  Fix GH-17879: readfile_variation8-win32.phpt test conflict
cmb69 added a commit that referenced this issue Feb 21, 2025
@cmb69
Merge branch 'PHP-8.4'
49d798a 
* PHP-8.4:
  Fix GH-17879: readfile_variation8-win32.phpt test conflict
charmitro pushed a commit to wasix-org/php that referenced this issue Mar 13, 2025
@cmb69 @charmitro
Fix phpGH-17879: readfile_variation8-win32.phpt test conflict
b48dba5 
Apparently a copy and paste issue.

Closes phpGH-17881.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmb69 cmb69

Labels
Bug Category: Tests Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GH-17879: readfile_variation8-win32.phpt test conflict cmb69/php-src
2 participants
@cmb69 @Girgias