Skip to content

Sync ext/dom class synopses with stubs based on PHP 8.4 changes #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

kocsismate
Copy link
Member

this is for PHP 8.4 when the time comes.

@kocsismate kocsismate marked this pull request as draft October 29, 2023 12:05
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback so far :)

</entry>
</row>
<row>
<entry>8.3.0</entry>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry doesn't belong to this PR ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes, thanks!

@Girgias Girgias added this to the PHP 8.4 milestone Oct 29, 2023
@Girgias
Copy link
Member

Girgias commented Nov 20, 2024

@nielsdos how usable is this?

@nielsdos
Copy link
Member

Forgot abt this. The constants are already documented, what this PR has though that is not yet on the doc page is the changelog entry.

nielsdos added a commit to nielsdos/doc-en that referenced this pull request Nov 21, 2024
Includes missing 8.3 and 8.4 changes.

Closes phpGH-2893.

Co-authored-by: =?UTF-8?q?M=C3=A1t=C3=A9=20Kocsis?= <[email protected]>
@nielsdos nielsdos closed this in 4b6c8a5 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants