Skip to content

update string comparisons possible returns. #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

update string comparisons possible returns. #1857

merged 2 commits into from
Oct 6, 2022

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen added this to the PHP 8.2 milestone Sep 30, 2022
cmb69
cmb69 reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

All affected functions would need changelog entries; it probably makes sense to define an XML entity for that.

@devnexen devnexen force-pushed the strcmp_ret_changes branch 2 times, most recently from e30f5ec to 766f562 Compare October 4, 2022 23:49
@devnexen devnexen force-pushed the strcmp_ret_changes branch from 766f562 to 84387c2 Compare October 4, 2022 23:51
@cmb69
Copy link
Member

cmb69 commented Oct 5, 2022

I pushed a commit with the missing changelog entries; I guess the wording can be improved. What do you think, @devnexen?

@devnexen
Copy link
Member Author

devnexen commented Oct 5, 2022

thanks @cmb69 looks ok to me

@cmb69
Copy link
Member

cmb69 commented Oct 6, 2022

So I'm going to commit. :)

@cmb69 cmb69 merged commit a3573c1 into php:master Oct 6, 2022
@saundefined saundefined mentioned this pull request Oct 7, 2022
Closed
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
@devnexen @tiffany-taylor
Update string comparisons possible returns
528dc09 
Co-authored-by: Christoph M. Becker <[email protected]>

Closes phpGH-1857.
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
@devnexen @claudepache
Update string comparisons possible returns
36e29fa 
Co-authored-by: Christoph M. Becker <[email protected]>

Closes phpGH-1857.
@devnexen devnexen deleted the strcmp_ret_changes branch November 30, 2024 10:23
@drealecs drealecs mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @cmb69