Skip to content

add FILTER_FLAG_GLOBAL_RANGE documentation #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

realFlowControl
Copy link
Contributor

@realFlowControl realFlowControl commented Sep 9, 2022

Hey there 🖖

this will add documentation for FILTER_FLAG_GLOBAL_RANGE as found in #1803 and added to PHP 8.2 with php/php-src@d8fc05c
I was thinking to write down all global IP ranges (as you can see in the docs for FILTER_FLAG_NO_PRIV_RANGE), but it turns out that these are quite a few. So I thought it might be sufficient to link to the RFC where those global ranges are defined.

WDYT?

Kind regards
Florian

@saundefined saundefined added this to the PHP 8.2 milestone Sep 9, 2022
@saundefined
Copy link
Member

Thanks! Perhaps, the changelog entry should be added 🤔

@realFlowControl
Copy link
Contributor Author

Changelog entry for FILTER_FLAG_GLOBAL_RANGE ✔️

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Besides the markup (see comment below), this looks good to me.

Co-authored-by: Christoph M. Becker <[email protected]>
@Girgias Girgias merged commit de489ba into php:master Sep 26, 2022
@realFlowControl realFlowControl deleted the docs/filter-global-range branch September 26, 2022 10:03
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
Co-authored-by: Florian Engelhardt <[email protected]>
Co-authored-by: Christoph M. Becker <[email protected]>
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
Co-authored-by: Florian Engelhardt <[email protected]>
Co-authored-by: Christoph M. Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants