Skip to content

socket extension update related to last entries. #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jun 3, 2022

No description provided.

@devnexen devnexen added this to the PHP 8.2 milestone Jun 6, 2022
@cmb69
Copy link
Member

cmb69 commented Jun 6, 2022

Thank you! This looks already good to me, so please switch to "ready for review", unless you're planning to work on this. Having the 8.2 milestone should be sufficient to postpone the merge.

@devnexen
Copy link
Member Author

devnexen commented Jun 6, 2022

waiting few more constants to be merged first :-)

@devnexen devnexen marked this pull request as ready for review June 6, 2022 14:12
@devnexen devnexen force-pushed the socket_ext_update branch 4 times, most recently from 7977c77 to 0c2b694 Compare June 11, 2022 12:12
@devnexen devnexen force-pushed the socket_ext_update branch 2 times, most recently from e25ea1c to a41c638 Compare June 30, 2022 20:14
@devnexen devnexen force-pushed the socket_ext_update branch 2 times, most recently from ad431ab to 794346b Compare July 10, 2022 20:49
@devnexen devnexen force-pushed the socket_ext_update branch 2 times, most recently from 5861950 to cf26a1c Compare July 27, 2022 18:31
@devnexen devnexen force-pushed the socket_ext_update branch 2 times, most recently from 79491c8 to 00d2b55 Compare September 20, 2022 12:33
@devnexen devnexen requested a review from cmb69 September 25, 2022 13:30
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

</term>
<listitem>
<simpara>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Availability info missing:

Suggested change
Available as of PHP 8.2.0

Same for the other new constants in this file.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devnexen devnexen merged commit a109454 into php:master Sep 27, 2022
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
@devnexen devnexen deleted the socket_ext_update branch November 30, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants